Skip to content

Commit

Permalink
Dim console calls on additional Effect invocations due to `StrictMo…
Browse files Browse the repository at this point in the history
…de` (#29007)

DiffTrain build for commit 3ac551e.
  • Loading branch information
eps1lon committed May 22, 2024
1 parent 1dcb0df commit faeda8b
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<286f871bd1498529f1c4a240e3588ad5>>
* @generated SignedSource<<e572e12f289b369da00c2c334d15c54d>>
*/

'use strict';
Expand Down Expand Up @@ -21988,6 +21988,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS

function doubleInvokeEffectsOnFiber(root, fiber) {
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
setIsStrictModeForDevtools(true);
disappearLayoutEffects(fiber);

if (shouldDoubleInvokePassiveEffects) {
Expand All @@ -21999,6 +22000,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
if (shouldDoubleInvokePassiveEffects) {
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
}

setIsStrictModeForDevtools(false);
}

function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
Expand Down Expand Up @@ -23303,7 +23306,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-rc-d64da7b1';
var ReactVersion = '19.0.0-rc-143c3a2f';

/*
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
217b2ccf160d7594a926d276a75c7312b299be4d
3ac551e855f9bec3161da2fc8787958aa62113db
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c3dfb8294efc9a95c7b084ad29cac4c4>>
* @generated SignedSource<<a69173f58e67e3c442c5241c04c2e053>>
*/

'use strict';
Expand Down Expand Up @@ -24710,6 +24710,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS

function doubleInvokeEffectsOnFiber(root, fiber) {
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
setIsStrictModeForDevtools(true);
disappearLayoutEffects(fiber);

if (shouldDoubleInvokePassiveEffects) {
Expand All @@ -24721,6 +24722,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
if (shouldDoubleInvokePassiveEffects) {
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
}

setIsStrictModeForDevtools(false);
}

function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
Expand Down Expand Up @@ -26042,7 +26045,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-rc-a8857e8e';
var ReactVersion = '19.0.0-rc-bb385be5';

/*
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<41909aca302c98b3f31b275cee319e39>>
* @generated SignedSource<<55f31038f2be45dd38383c50d946e009>>
*/

'use strict';
Expand Down Expand Up @@ -25060,6 +25060,7 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(root, parentFiber, isInS

function doubleInvokeEffectsOnFiber(root, fiber) {
var shouldDoubleInvokePassiveEffects = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : true;
setIsStrictModeForDevtools(true);
disappearLayoutEffects(fiber);

if (shouldDoubleInvokePassiveEffects) {
Expand All @@ -25071,6 +25072,8 @@ function doubleInvokeEffectsOnFiber(root, fiber) {
if (shouldDoubleInvokePassiveEffects) {
reconnectPassiveEffects(root, fiber, NoLanes, null, false);
}

setIsStrictModeForDevtools(false);
}

function doubleInvokeEffectsInDEVIfNecessary(root, fiber, parentIsInStrictMode) {
Expand Down Expand Up @@ -26392,7 +26395,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-rc-a63abc4e';
var ReactVersion = '19.0.0-rc-5945dec0';

/*
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol
Expand Down

0 comments on commit faeda8b

Please sign in to comment.