Skip to content

Commit

Permalink
[Flight] Warn if this argument is passed to .bind of a Server Referen…
Browse files Browse the repository at this point in the history
…ce (#28380)

This won't ever be serialized and is likely just a mistake.

This should be covered by the "use server" compiler since it ensures
that something that accepts a "this" won't be allowed to compile and if
it doesn't accept it, TypeScript should ideally forbid it to be passed.

So maybe this is unnecessary.

DiffTrain build for commit 65a0e2b.
  • Loading branch information
sebmarkbage committed Feb 19, 2024
1 parent 953baa5 commit ff7932d
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25697,7 +25697,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-canary-9444c51c7-20240219";
var ReactVersion = "18.3.0-canary-65a0e2b25-20240219";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9179,7 +9179,7 @@ var devToolsConfig$jscomp$inline_1018 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-9444c51c7-20240219",
version: "18.3.0-canary-65a0e2b25-20240219",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1199 = {
Expand Down Expand Up @@ -9210,7 +9210,7 @@ var internals$jscomp$inline_1199 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-9444c51c7-20240219"
reconcilerVersion: "18.3.0-canary-65a0e2b25-20240219"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1200 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9607,7 +9607,7 @@ var devToolsConfig$jscomp$inline_1060 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-9444c51c7-20240219",
version: "18.3.0-canary-65a0e2b25-20240219",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1240 = {
Expand Down Expand Up @@ -9638,7 +9638,7 @@ var internals$jscomp$inline_1240 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-9444c51c7-20240219"
reconcilerVersion: "18.3.0-canary-65a0e2b25-20240219"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1241 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "18.3.0-canary-9444c51c7-20240219";
var ReactVersion = "18.3.0-canary-65a0e2b25-20240219";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -590,4 +590,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-9444c51c7-20240219";
exports.version = "18.3.0-canary-65a0e2b25-20240219";
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-9444c51c7-20240219";
exports.version = "18.3.0-canary-65a0e2b25-20240219";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9444c51c7e44936c24e1f44db905cfd45c51cff3
65a0e2b25ec4642f83c32d7599b5252c3955a60b

0 comments on commit ff7932d

Please sign in to comment.