-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullifying value on <progress /> should return component to indeterminate state #1431
Comments
…/> should return component to indeterminate state.
… to 'value'. It seems to be the safest route to affect 'value' and therefore 'position' attributes for the progress DOM element without affecting other DOM elements which rely on the 'value' attribute and its side effects Closes facebook#1431
This is my first time contributing to the React project so it will probably take some time before they get around to giving it a more careful look and see if my proposed solution is an acceptable one. |
Hey @danielschonfeld. Thanks for pitching in (#1437) to try to fix this! I've left some general comments about writing code and tests in your commits. I see that you've introduced a new attribute named I haven't had time to look into the problem yet, so take what I say with a grain of salt, but could it be that there's just a plain old, fixable bug, with respect to |
Possible fix: #1510 |
Looks like this issue closed: I've just verified. This is fixed! |
Expected:
Given a
<progress />
component, when its value property transitions from being a float to beingnull
, I expect thevalue
attribute of the<progress>
tag to become unspecified, putting the control in the "indeterminate" state (the state with the animating barbershop pole pattern).Actual:
When transitioning from being a float to being
null
, the value attribute of the<progress>
tag becomes"0"
.Test case:
http://jsfiddle.net/kb3gN/1981/
The text was updated successfully, but these errors were encountered: