Bug: SSR of malformed? meta renders nothing(working in 18.2)
#25928
Comments
eps1lon
changed the title
meta tag throws in next release (working in 18.2)meta renders nothing(working in 18.2)
eps1lon
added a commit
that referenced
this issue
Feb 10, 2023
## Summary Due to #25928 the attribute fixture could no longer finish since it expects at least something to render. But since Fizz currently breaks down completely on malformed `<meta>` tags, the fixture could no longer handle this. The fixture now renders valid types for `meta` tags. Note that the snapshot change to `viewTarget`` is already on `main`. Review by commit helps to understand this. Added `html[lang]` so that we test at least one standard attribute on `<html>`. `version` is obsolete so results are not that trustworthy. ## How did you test this change? With Chrome Version 109.0.5414.119 (Official Build) (64-bit) - `yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start`
github-actions bot
pushed a commit
that referenced
this issue
Feb 10, 2023
## Summary Due to #25928 the attribute fixture could no longer finish since it expects at least something to render. But since Fizz currently breaks down completely on malformed `<meta>` tags, the fixture could no longer handle this. The fixture now renders valid types for `meta` tags. Note that the snapshot change to `viewTarget`` is already on `main`. Review by commit helps to understand this. Added `html[lang]` so that we test at least one standard attribute on `<html>`. `version` is obsolete so results are not that trustworthy. ## How did you test this change? With Chrome Version 109.0.5414.119 (Official Build) (64-bit) - `yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start` DiffTrain build for [b8ae89f](b8ae89f) [View git log for this commit](https://github.com/facebook/react/commits/b8ae89f38288bfae37dff54fa1ec4bf3b4555ed5)
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this issue
Jan 5, 2024
## Summary Due to facebook/react#25928 the attribute fixture could no longer finish since it expects at least something to render. But since Fizz currently breaks down completely on malformed `<meta>` tags, the fixture could no longer handle this. The fixture now renders valid types for `meta` tags. Note that the snapshot change to `viewTarget`` is already on `main`. Review by commit helps to understand this. Added `html[lang]` so that we test at least one standard attribute on `<html>`. `version` is obsolete so results are not that trustworthy. ## How did you test this change? With Chrome Version 109.0.5414.119 (Official Build) (64-bit) - `yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start` DiffTrain build for [b8ae89f38288bfae37dff54fa1ec4bf3b4555ed5](facebook/react@b8ae89f) [View git log for this commit](https://github.com/facebook/react/commits/b8ae89f38288bfae37dff54fa1ec4bf3b4555ed5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
React version:
Steps To Reproduce
<meta name="test" />(renderToStringandrenderToReadableStream)Link to code example:
The current behavior
Renders empty string
The expected behavior
Renders
<meta name="test" />Don't know if that's a valid use case but it should at least warn that the meta tag is malformed?
This broke the attribute fixture (originally reported in #25927).
Also:
<meta name="description" content={content} />renders nothing unlesscontentis a string.<meta http-equiv />i.e. anyhttp-equivusage no longer renders anything. It used to warn at least.The text was updated successfully, but these errors were encountered: