Fix ReactPartialRenderer in production #10300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hahaha, I seriously just committed and was about to open an identical PR when I saw you beat me to it. Ideally, we'd run tests in prod mode as part of the build to catch bugs like these, but in the mean time, this is the right fix. I approve! |
aickin
approved these changes
Jul 27, 2017
#10273 :-) |
|
@keyanzhang Yes, please add a sanity check. Thanks! |
This was referenced Jul 27, 2017
Closed
|
I added tests in #10308. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10299. Seems like
dangerousStyleValueandhyphenateStyleNameare not dev-only helpers. In production, the entire__DEV__branch gets removed and these 2 functions becomeundefined.