Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find callsites that would call toString() if we pass attributes through #10416

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Find callsites that would call toString() if we pass attributes through #10416

merged 2 commits into from
Aug 11, 2017

Commits on Aug 9, 2017

  1. Find callsites that would call toString() if we pass attributes through

    @gaearon
    gaearon committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    d0e3cdd View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. Warn for all object unknown props, not just 'toString' ones 

    fixing this as per Sebastian's feedback, because we want to find all
objects and not just ones with 'toString' defined. Because there may be
other corner cases and issues that are revealed.
    Flarnie Marchan committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    e881c39 View commit details
    Browse the repository at this point in the history