Update error codes on docs branch #10622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** This just updated the error codes on the docs. For my future self, recording the steps it took to get here: - On master, run `npm run build -- --extract-errors` - Create a commit with those changes, and open a PR (facebook#10619) - Cherry-pick that commit onto 15-stable, and open a PR (facebook#10621) - Update the error codes on the `gh-pages branch` by doing the following based on docs (https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact): - Set up a sister directory to `react` with `gh-pages` checked out, and call it `react-gh-pages` - In your `react` repo, with `15-stable` checked out and the error-codes update cherry-picked, run: `cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake release` - `cd ../react-gh-pages` and check in those changes, create a commit/PR - Manually test running the docs **why make this change?:** Even though this is just an RC, and not a final major release, we still want the docs to be as up-to-date as possible. **test plan:** Run the docs locally and make sure things work. (Flarnie will insert screenshots.) **issue:** facebook#8854
gaearon
requested changes
Sep 6, 2017
sophiebits
approved these changes
Sep 6, 2017
|
(As long as this is landed with #10621.) |
gaearon
approved these changes
Sep 6, 2017
|
Ah, I missed that one, thanks for explaining! |
|
Ah - in the past we had manually committed to this branch in order to update the docs faster than CI might run, but in this case there is no real rush. We can wait for #10621 to land. |
|
Looks like CI failing here is normal? https://circleci.com/gh/facebook/react/tree/gh-pages |
|
On my phone, but the 15-stable branch is the one to look at. And yes, fine landing this as long as it's just being built from the latest code in 15-stable. |
|
Oh, yes, that seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
This just updated the error codes on the docs.
For my future self, recording the steps it took to get here:
npm run build -- --extract-errors(Update error codes and results.json #10619)
(Update error codes on 15-stable branch #10621)
gh-pages branchby doing thefollowing based on docs
(https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact):
reactwithgh-pageschecked out,and call it
react-gh-pagesreactrepo, with15-stablechecked out and theerror-codes update cherry-picked, run:
cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake releasecd ../react-gh-pagesand check in those changes, create acommit/PR
why make this change?:
Even though this is just an RC, and not a final major release, we still
want the docs to be as up-to-date as possible.
test plan:
Run the docs locally and make sure things work.
issue:
#8854