Make ReactDOM.createPortal() official #10675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
portal-stuff
branch
from
6508b7c
to
36cbeb1
Compare
gaearon
force-pushed
the
portal-stuff
branch
from
36cbeb1
to
1c7af86
Compare
sebmarkbage
approved these changes
Sep 11, 2017
Closed
Merged
|
Is there documentation on this anywhere? |
|
There will be. :-) |
|
@gaearon Do you have a rough idea of when the documentation will be available? A week? A month? Thanks very much! |
|
Together with React 16, in a few days. We provide documentation for new features at the same time they are released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might later want to move portal creation to
ReactAPI that would be renderer-agnostic and work across renderers but it's likely that it will be a superset of the current API.So we might as well call the current API "stable". Especially because it's the only migration path for top-level render returning
nullinside a batch in 16.See individual commits. I added validation because otherwise you get a very confusing error when you pass something else. Also helps us make it clear it's currently not supported by SSR.
Open question: what happens if you do
{isClient && ReactDOM.createPortal(...)}? Does it cause a mismatch on initial render? I don't know. Worth checking.