Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for createHTMLDocument API specific to IE11 #10921

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

leidegre
Copy link
Contributor

The createHTMLDocument API title parameter is not optional in IE while other browsers don't care IE11 will throw if an argument is not passed. This only impacts react.dom.development not react.dom.production.

Fixes issue #10865

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Format your code with prettier (npm run prettier).
  6. Make sure your code lints (npm run lint).
  7. Run the Flow typechecks (npm run flow).
  8. If you haven't already, complete the CLA.

The createHTMLDocument API title parameter is not optional in IE while other browsers don't care IE11 will throw if an argument is not passed. This only impacts react.dom.development not react.dom.production.
@gaearon
Copy link
Collaborator

gaearon commented Sep 28, 2017

Looks great. Thanks!

@gaearon gaearon merged commit 857ed18 into facebook:master Sep 28, 2017
@leidegre leidegre deleted the react-dom-development-ie11-fix branch September 28, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants