Make sure all class constructors in the docs call super with props #11105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 551031e |
|
Closed by reactjs/react.dev#8 |
This was referenced Aug 7, 2020
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frankly I'm not sure whether it is strictly necessary to do "always call the base constructor with props", but it is mentioned here so I think this should be enforced in the documentation at the very least.
Some of the test fixtures in
/srchave components which do not call thesuper()withpropsas well. I can make a PR to fix those if you like.Also, I understand that the docs page is undergoing migration at the moment. If I should be making doc changes in the new repo or hold off further changes until the migration is complete, do let me know.