Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event plugins to addons #1170

Closed
wants to merge 1 commit into from
Closed

Conversation

petehunt
Copy link
Contributor

I did this in the most API-constrained way possible. Will write docs.

@zpao
Copy link
Member

zpao commented Feb 26, 2014

Aw, we lost ABC order

@zpao
Copy link
Member

zpao commented Apr 18, 2014

Anything else need to be done here @petehunt?

@ryanseddon
Copy link
Contributor

Just did a custom build with these changes and setup a demo but the onTouchTap event doesn't trigger in iOS but it does on desktop Chrome?

@sophiebits
Copy link
Collaborator

Try adding React.initializeTouchEvents(true) before any of your app code, if you don't have it already.

@ryanseddon
Copy link
Contributor

No that doesn't seem to work either, see updated test case.

@tmcw
Copy link
Contributor

tmcw commented Jun 21, 2014

The updated test case works for me in Mobile Safari on an iPhone 5S & in an emulator.

@jbrantly
Copy link
Contributor

jbrantly commented Jul 7, 2014

👍 I would love to see this merged

@zpao
Copy link
Member

zpao commented Aug 13, 2014

Nah. Let's hold off because supporting this is going to suck. We should figure something out for 1.0, so we can come back around to it then.

@slorber
Copy link
Contributor

slorber commented Jul 17, 2015

+1

4 similar comments
@micky2be
Copy link

+1

@dzannotti
Copy link

+1

@sathify
Copy link

sathify commented Aug 24, 2015

+1

@alancmclean
Copy link

+1

@zpao
Copy link
Member

zpao commented Sep 3, 2015

Please don't add any more "+1" comments. If you don't have anything constructive, don't comment at all.

@mhart
Copy link

mhart commented Sep 3, 2015

@zpao is there a discussion happening around this somewhere? Your last comment was:

We should figure something out for 1.0, so we can come back around to it then.

@zpao
Copy link
Member

zpao commented Sep 3, 2015

No, not that I know of.

@mhart
Copy link

mhart commented Sep 3, 2015

So what's the status of it do you think?

@mhart
Copy link

mhart commented Sep 3, 2015

@zpao So this issue, along with #436 are both referenced from https://github.com/zilverline/react-tap-event-plugin – where it says "When Facebook solves #436 and #1170, this repo will disappear". And http://react-components.com/component/material-ui#react-tap-event-plugin where it says "This dependency is temporary and will go away once react v1.0 is released"

I believe that's why there's still interest in this issue/PR – really I think everyone's just interested in what the story is for tap events for React.

So is there anywhere better to follow the status of this in React, or is this PR (or #436) the best place?

@sophiebits
Copy link
Collaborator

Let's go with #436.

@mhart
Copy link

mhart commented Sep 3, 2015

Cool, thanks @spicyj !

@c0b41
Copy link

c0b41 commented Oct 20, 2015

+1

1 similar comment
@anaibol
Copy link

anaibol commented Feb 25, 2016

+1

@facebook facebook locked and limited conversation to collaborators Feb 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.