Additional release script options for publishing canary versions #12219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `branch` specifies a branch other than master - `local` skips pulling from the remote branch and checking CircleCI - `tag` specifies an npm dist tag other than `latest` or `next` We may add a higher-level `canary` option in the future.
bvaughn
reviewed
Feb 13, 2018
scripts/release/config.js
Outdated
| { | ||
| name: 'local', | ||
| type: Boolean, | ||
| description: "Don't pull changes from the remote branch. Also skips CI.", |
There was a problem hiding this comment.
nit: Don't push or pull changes from repo repo. Don't check CI status.
| } | ||
| } else { | ||
| // Any tag besides `latest` is a prerelease | ||
| isPrerelease = tag === 'latest'; |
There was a problem hiding this comment.
Isn't this the exact opposite of what you want? (Don't you want !==)
There was a problem hiding this comment.
Ha yes I hit this exact bug when I did the release and neglected to include the change in the commit :D
| const errors = []; | ||
| const isPrerelease = semver.prerelease(version); | ||
| const tag = isPrerelease ? 'next' : 'latest'; | ||
| let isPrerelease; |
There was a problem hiding this comment.
I think isPrerelease should always be determined by:
isPrerelease = semver.prerelease(version);And I think the script should fail (with an error) if we ever try to combine the "latest" tag with a version that isn't x.x.x (eg 16.3.0-alpha.0 and "latest" should be an error)
- Updated description of `local` option - Throws if the `latest` tag is specified for a prerelease version
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…ebook#12219) * Additional release script options for publishing canary versions - `branch` specifies a branch other than master - `local` skips pulling from the remote branch and checking CircleCI - `tag` specifies an npm dist tag other than `latest` or `next` We may add a higher-level `canary` option in the future. * Address Brian's feedback: - Updated description of `local` option - Throws if the `latest` tag is specified for a prerelease version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branchspecifies a branch other than masterlocalskips pulling from the remote branch and checking CircleCItagspecifies an npm dist tag other thanlatestornextWe may add a higher-level
canaryoption in the future.Test plan: I used this to publish 16.4.0-alpha.7926752 and it worked.