Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context stack misalignment caused by error replay #12508

Merged
merged 5 commits into from
Apr 2, 2018
Merged

Fix context stack misalignment caused by error replay #12508

merged 5 commits into from
Apr 2, 2018

Commits on Apr 2, 2018

  1. Add regression tests for error boundary replay bugs

    @gaearon
    gaearon committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    f995034 View commit details
    Browse the repository at this point in the history

  2. Ensure the context stack is aligned if renderer throws

    @gaearon
    gaearon committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    1130f89 View commit details
    Browse the repository at this point in the history

  3. Always throw when replaying a failed unit of work 

    Replaying a failed unit of work should always throw, because the render
phase is meant to be idempotent, If it doesn't throw, rethrow the
original error, so React's internal stack is not misaligned.
    @acdlite
    acdlite committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    220af1e View commit details
    Browse the repository at this point in the history

  4. Reset originalReplayError after replaying

    @acdlite
    acdlite committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    602a206 View commit details
    Browse the repository at this point in the history

  5. Typo fix

    @gaearon
    gaearon authored Apr 2, 2018
    Configuration menu
    Copy the full SHA
    03cc7c4 View commit details
    Browse the repository at this point in the history