Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Modes in the component stack #13240

Merged
merged 3 commits into from
Jul 19, 2018
Merged

Include Modes in the component stack #13240

merged 3 commits into from
Jul 19, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 19, 2018

Alternative to #13109.

Now that the component stack is always attached automatically, this seems like a low-effort way to know the mode without exposing more methods on the isomorphic frame module. This should allow us to parse the stack to determine whether we're in a strict root, and be helpful when debugging (e.g. "where does the strict/async mode start in my tree?").

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig this change.

@gaearon gaearon merged commit 3d3506d into facebook:master Jul 19, 2018
@gaearon gaearon mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants