Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance dev warnings for forwardRef render function (#13627) #13636

Merged
merged 3 commits into from
Sep 13, 2018
Merged

Enhance dev warnings for forwardRef render function (#13627) #13636

merged 3 commits into from
Sep 13, 2018

Commits on Sep 13, 2018

  1. Enhance dev warnings for forwardRef render function 

    - For 0 parameters: Do not warn because it may be due to usage of the
  arguments object.

- For 1 parameter: Warn about missing the 'ref' parameter.

- For 2 parameters: This is the ideal. Do not warn.

- For more than 2 parameters: Warn about undefined parameters.
    @andresroberto
    andresroberto authored and Andres Rojas committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    46629e6 View commit details
    Browse the repository at this point in the history

  2. Make test cases for forwardRef warnings more realistic

    @andresroberto
    andresroberto authored and Andres Rojas committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    04b6eef View commit details
    Browse the repository at this point in the history

  3. Add period to warning sentence

    @andresroberto
    andresroberto authored and Andres Rojas committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    5c832cc View commit details
    Browse the repository at this point in the history