[react-is] add back proper AsyncMode symbol, for back compat #13959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Partial revert of facebook#13732 - Fixes facebook#13958.
Details of bundled changes.Comparing: 275e76e...fa814c2 scheduler
Generated by 🚫 dangerJS |
ljharb
force-pushed
the
react-is-async-mode
branch
from
3ea64dd
to
fa814c2
Compare
|
I have confirmed that these changes cause my enzyme tests in react 16.3 to pass. |
gaearon
approved these changes
Oct 31, 2018
|
Seems okay. We shouldn't have exposed this without the prefix but since we did... |
ljharb
added a commit
to enzymejs/enzyme
that referenced
this pull request
Nov 7, 2018
- Fixes a breaking change wrt `AsyncMode`; reverts 7a36b5a. See facebook/react#13959
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…k#13959) - Partial revert of facebook#13732 - Fixes facebook#13958.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't add tests for
isAsyncModebecause #13732 didn't preserve any - happy to add them if needed.