-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synchronous Suspense] Don't delete children of suspended component #14157
[Synchronous Suspense] Don't delete children of suspended component #14157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think we didn't catch this in the code or the simple tests we added?
Have we hit terminal complexity?
Details of bundled changes.Comparing: 3d8bda7...c41126f scheduler
Generated by 🚫 dangerJS |
@sebmarkbage I blame it on sloppiness on my part when I was updating the tests in #13823. But yeah, it's getting pretty complex, too. There are a few things in our Suspense implementation that are unusual:
Any one of these quirks by themselves isn't so complex, but we have to consider all of them together. I still think they're worth it, but if we ever decide it's too much, we might need to drop one of these constraints. |
Vestigial behavior that should have been removed in facebook#13823. Found using the Suspense fuzz tester in facebook#14147.
9e947d1
to
c41126f
Compare
…acebook#14157) Vestigial behavior that should have been removed in facebook#13823. Found using the Suspense fuzz tester in facebook#14147.
…acebook#14157) Vestigial behavior that should have been removed in facebook#13823. Found using the Suspense fuzz tester in facebook#14147.
Vestigial behavior that should have been removed in #13823.
Found using the Suspense fuzz tester in #14147.