Publish a local release (canary or stable) to NPM #14260

bvaughn · 2018-11-17T16:52:08Z

Issue #14201. Builds on top of #14255 (view the delta).

This PR adds the final publish script and does a bit of cleanup of the pre-existing scripts. (For example, the build script is no longer needed and so it has been removed.)

This PR also removes the pre-build "version-check" behavior since there is an expected version mismatch between canary packages and the embedded React version (used by DevTools). If this change is controversial, I'm happy to elaborate on why I chose this detail and discuss alternatives.

Learn more about these new release scripts here.

Demos

Checking out a Circle CI build for a canary release

Preparing a canary release to be promoted to stable

Publishing a release

Resuming an interrupted publish (dry run)

Creating a local canary (escape hatch)

Note that I trimmed the middle out of this GIF since building takes a long time.

bvaughn · 2018-11-18T18:57:29Z

My last commit was totally unnecessary, but I thought I might as well replace our scattered chalk styles with a shared theme. This has the (admittedly small) benefit of making repeated things (e.g. package name or version) more recognizable at a glance, since they are consistently formatted now:

These colors look best on a dark terminal themes, but I think they are also legible with a white terminal background. The yellow and green text are a little bit low contrast with light themes, but...it's probably okay?

Also updated Circle CI build script to generate and add a build-info.json file to artifacts

…aging

bvaughn · 2018-11-19T19:07:34Z

Rebased and added a new artifact to the Circle CI config– the error codes JSON. Going to let CI run to see if I configured it correctly. If so, I'm going to try to use this artifact when promoting a canary to stable so that I can avoid re-building it.

This commit also temporarily changes an error message so I can verify the updated error codes JSON

apalm · 2018-11-19T20:15:55Z

scripts/release/prepare-stable-commands/update-stable-version-numbers.js

+  console.log(
+    theme`A full diff is availbale at {path ${relative(cwd, diffPath)}}.`
+  );
+  await confirm('Do changes changes look correct?');


Typo on "availbale" in line 161 too

Whoops, yes.

bvaughn · 2018-11-19T21:03:52Z

Error codes are now stored as Circle CI artifacts and automatically downloaded (and staged) after publishing (for stable releases). If the published release was a local build, instructions are provided for updating error codes.

CI build

Local build

bvaughn · 2018-11-20T23:09:56Z

During our chat today, Sunil, it occurred to me that I could pretty easily auto-stage changes to package JSONs after a stable publish by just copying over portions of the just-published package JSON (40dde41).

bvaughn · 2018-11-22T01:04:51Z

🕺

threepointone · 2018-11-23T16:08:37Z

the code looks good to me, and we discussed this in person. I'm trying to actually run it on my machine today.

ps - er, where do I approve this? I see this

bvaughn · 2018-11-23T19:21:27Z

Top right of the page should have options to approve/request changes/comment.

…n build/dist

threepointone

tested/verified dry runs

New release scripts. Learn more at https://github.com/facebook/react/blob/master/scripts/release/README.md

facebook-github-bot added the CLA Signed label Nov 17, 2018

bvaughn mentioned this pull request Nov 17, 2018

Automated incremental React releases #14201

Closed

31 tasks

facebook deleted a comment from sizebot Nov 17, 2018

bvaughn force-pushed the automated-release-scripts-part-4 branch from 26001f6 to 8f6e199 Compare November 17, 2018 19:47

bvaughn changed the title ~~[WIP] Publish a local release (canary or stable) to NPM~~ Publish a local release (canary or stable) to NPM Nov 17, 2018

bvaughn requested review from acdlite and gaearon and removed request for acdlite November 17, 2018 19:53

bvaughn mentioned this pull request Nov 18, 2018

Promote a canary from NPM to be a stable release #14255

Closed

Brian Vaughn added 12 commits November 19, 2018 10:18

Download Circle CI artifact and prepare canary release

b55f38e

New create-canary script

0240640

Also updated Circle CI build script to generate and add a build-info.json file to artifacts

New prepare-canary release script

c197be7

Added release script README

71c1046

Shuffled around and tidied up

341ebb3

Added publish command and slightly refactored some other command mess…

bbb9d9e

…aging

Always log NPM commands (even if not dry run)

4d53087

Fixed resume check typo/bug

86d3036

Added check for build-info.json in files array

43ac899

Replaced chalk usage with shared theme for consistancy

1018c30

Updated release script README

baecb2e

Store error codes JSON as a build artifact also

26a00aa

bvaughn force-pushed the automated-release-scripts-part-4 branch from 5ff1d68 to 26a00aa Compare November 19, 2018 19:06

Brian Vaughn added 2 commits November 19, 2018 11:32

Store Circle CI build number in build-info.json

b3d1a81

This commit also temporarily changes an error message so I can verify the updated error codes JSON

Revert (intentional) temporary error message change

e624d14

apalm reviewed Nov 19, 2018

View reviewed changes

bvaughn mentioned this pull request Nov 19, 2018

Add basic release script snapshot test #14280

Merged

Download error-codes from Circle CI after publishing

3585929

bvaughn force-pushed the automated-release-scripts-part-4 branch from 8ba1f03 to 3585929 Compare November 19, 2018 22:16

bvaughn force-pushed the automated-release-scripts-part-4 branch from 4b99ae2 to 03182f4 Compare November 20, 2018 23:17

Update package JSONs automatically after stable release is publish

40dde41

bvaughn force-pushed the automated-release-scripts-part-4 branch from 03182f4 to 40dde41 Compare November 20, 2018 23:18

Brian Vaughn added 6 commits November 23, 2018 11:51

Fixed a typo

03abe2a

Updated fixtures/packaging tests to use build/node_modules rather tha…

8747fa6

…n build/dist

Added note about --dry flag for publish script to README

83745a7

Added {cwd} options to NPM pack-and-unpack commends

02774ef

Fixed another relative path issue for prepare-canary script

d30f652

Nit about pushstate-server usage

38c8aca

threepointone approved these changes Nov 23, 2018

View reviewed changes

bvaughn merged commit 686f106 into facebook:master Nov 23, 2018

bvaughn deleted the automated-release-scripts-part-4 branch November 23, 2018 20:37

This was referenced Nov 23, 2018

Create a canary from current Git branch and revision #14244

Closed

Download Circle CI artifact and prepare canary release #14225

Closed

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019

Publish a local release (canary or stable) to NPM (facebook#14260)

8481dff

New release scripts. Learn more at https://github.com/facebook/react/blob/master/scripts/release/README.md

n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019

Publish a local release (canary or stable) to NPM (facebook#14260)

63f2264

New release scripts. Learn more at https://github.com/facebook/react/blob/master/scripts/release/README.md

NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020

Publish a local release (canary or stable) to NPM (#14260)

05b2a7a

New release scripts. Learn more at https://github.com/facebook/react/blob/master/scripts/release/README.md

elas7 mentioned this pull request Nov 6, 2021

Delete unused Circle CI scripts. #22710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish a local release (canary or stable) to NPM #14260

Publish a local release (canary or stable) to NPM #14260

bvaughn commented Nov 17, 2018 •

edited

Loading

bvaughn commented Nov 18, 2018 •

edited

Loading

bvaughn commented Nov 19, 2018

apalm Nov 19, 2018

matpag Nov 19, 2018

bvaughn Nov 19, 2018

bvaughn commented Nov 19, 2018

bvaughn commented Nov 20, 2018 •

edited

Loading

bvaughn commented Nov 22, 2018

threepointone commented Nov 23, 2018

bvaughn commented Nov 23, 2018

threepointone left a comment

Publish a local release (canary or stable) to NPM #14260

Publish a local release (canary or stable) to NPM #14260

Conversation

bvaughn commented Nov 17, 2018 • edited Loading

Issue #14201. Builds on top of #14255 (view the delta).

Demos

Checking out a Circle CI build for a canary release

Preparing a canary release to be promoted to stable

Publishing a release

Resuming an interrupted publish (dry run)

Creating a local canary (escape hatch)

bvaughn commented Nov 18, 2018 • edited Loading

bvaughn commented Nov 19, 2018

apalm Nov 19, 2018

Choose a reason for hiding this comment

matpag Nov 19, 2018

Choose a reason for hiding this comment

bvaughn Nov 19, 2018

Choose a reason for hiding this comment

bvaughn commented Nov 19, 2018

CI build

Local build

bvaughn commented Nov 20, 2018 • edited Loading

bvaughn commented Nov 22, 2018

threepointone commented Nov 23, 2018

bvaughn commented Nov 23, 2018

threepointone left a comment

Choose a reason for hiding this comment

bvaughn commented Nov 17, 2018 •

edited

Loading

bvaughn commented Nov 18, 2018 •

edited

Loading

bvaughn commented Nov 20, 2018 •

edited

Loading