Clear fields on unmount of fiber to avoid memory leak #14276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Nov 19, 2018
| const alternate = current.alternate; | ||
| if (alternate !== null) { | ||
| alternate.child = null; | ||
| alternate.return = null; |
There was a problem hiding this comment.
Nit: reorder to match the order above? So it's easier to see they're the same.
gaearon
approved these changes
Nov 19, 2018
|
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Details of bundled changes.Comparing: d204747...2b9fe40 react-dom
Generated by 🚫 dangerJS |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Clear fields on unmount of fiber to avoid memory leak
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Clear fields on unmount of fiber to avoid memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #14218. In that PR, fields that we were unsure about were
nulled out. This changes thenulling out of fields to the two that we know are safe tonullout – specifically,memoizedStateandupdateQueue. This stops the memory leak we encounter when the associated fibers containing the references to the closures (stored in memoizedState) still exist after being unmounted