Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper-type fix for <progress> element not returning to an indeterminate state (#1431) #1443

Closed
wants to merge 5 commits into from
Closed

Wrapper-type fix for <progress> element not returning to an indeterminate state (#1431) #1443

wants to merge 5 commits into from

Commits on Apr 24, 2014

  1. Added a failing test. When the value prop of a progress component tra… 

    …nsitions from being set to being null, the progress component does not return to the "indeterminate" state (barbershop pole).
    Steven Luscher committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    7324b24 View commit details
    Browse the repository at this point in the history

  2. Created a ReactDOMProgress wrapper. Ensures that when the progress co… 

    …mponent's value is set to null or undefined, the progress element returns to the indeterminate state (barbershop pole).
    Steven Luscher committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    6f68303 View commit details
    Browse the repository at this point in the history

  3. Edited a comment in ReactDOMProgress to pass the linter.

    Steven Luscher committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    f2e8a55 View commit details
    Browse the repository at this point in the history

  4. Modified a one-line if statement to pass the linter.

    Steven Luscher committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    2566cca View commit details
    Browse the repository at this point in the history

  5. Skip the ReactDOMProgress tests if the <progress> element isn't suppo… 

    …rted by the test host.
    Steven Luscher committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    edbaa9e View commit details
    Browse the repository at this point in the history