Experimental event API - wrap async dispatched events #15299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where async dispatched events from event modules were not properly handled. Previously, before the refactor PR, async events were never batched together.
To ensure they such events are batched together, the
contextcreates a new event queue for async events and then restores the old event queue upon completion. To do this a new method on context is introduced, specificallywithAsyncDispatching. This method ensures that all async events inside the callback are properly batched together without conflicting with previous event queues. This also simplifies event queues, where previously they had the notion of phases (which isn't necessary now).@necolas to follow up with tests.
Ref #15257