Don't extract errors in CI #15758
Merged
Don't extract errors in CI #15758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
dont-extract-errors-in-ci
branch
from
97caacb
to
9c34bd9
Compare
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Disregard. Looks like you added a check to make sure we didn't forget to generate these. 👍 |
bvaughn
approved these changes
May 29, 2019
Removes `--extract-errors` argument from CI build script command. Instead, the author is expected to run `yarn extract-errors` locally or manually edit the error code map. The lint rule should be sufficient to catch unminified errors, but as an extra precaution, I added a post-build step that greps the production bundles. The post-build step works even if someone disables the lint rule for a specific line or file.
acdlite
force-pushed
the
dont-extract-errors-in-ci
branch
3 times, most recently
from
d824a39
to
fc36310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
--extract-errorsargument from CI build script command. Instead, the author is expected to runyarn extract-errorslocally or manually edit the error code map.The lint rule should be sufficient to catch unminified errors, but as an extra precaution, I added a post build step that greps the production bundles. The post-build step works even if someone disables the lint rule for a specific line or file.