Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flare] Add basic Scroll event responder module #15827

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jun 5, 2019

This is the start of the Scroll event responder module, as per the umbrella issue. It's missing much of the functionality and we'll need to think about how to write the tests.

At least with this is, we can possibly get some assistance from someone else who might want to fill in the rest of the functionality:

@sizebot
Copy link

sizebot commented Jun 5, 2019

Details of bundled changes.

Comparing: 7b28ad1...eb2977e

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events-hover.development.js 0.0% -0.0% 9.09 KB 9.09 KB 2.19 KB 2.19 KB UMD_DEV
react-events-hover.production.min.js 0.0% -0.1% 3.85 KB 3.85 KB 1.44 KB 1.44 KB UMD_PROD
react-events-drag.production.min.js 0.0% -0.1% 2.54 KB 2.54 KB 1.16 KB 1.16 KB UMD_PROD
ReactEventsScroll-dev.js n/a n/a 0 B 3.72 KB 0 B 1.17 KB FB_WWW_DEV
react-events.development.js 0.0% -0.3% 1.31 KB 1.31 KB 708 B 706 B UMD_DEV
react-events-focus-scope.development.js 0.0% -0.1% 4.79 KB 4.79 KB 1.45 KB 1.45 KB UMD_DEV
react-events.production.min.js 0.0% -0.2% 682 B 682 B 431 B 430 B UMD_PROD
react-events-focus-scope.production.min.js 0.0% -0.1% 2.01 KB 2.01 KB 1020 B 1019 B UMD_PROD
react-events.development.js 0.0% -0.2% 1.12 KB 1.12 KB 645 B 644 B NODE_DEV
react-events-focus-scope.development.js 0.0% -0.1% 4.6 KB 4.6 KB 1.4 KB 1.4 KB NODE_DEV
react-events-focus-scope.production.min.js 0.0% -0.1% 1.82 KB 1.82 KB 929 B 928 B NODE_PROD
react-events-focus.development.js 0.0% -0.1% 7.17 KB 7.17 KB 1.84 KB 1.84 KB UMD_DEV
react-events-scroll.development.js n/a n/a 0 B 3.93 KB 0 B 1.23 KB UMD_DEV
react-events-focus.production.min.js 0.0% -0.1% 3.08 KB 3.08 KB 1.19 KB 1.19 KB UMD_PROD
react-events-scroll.production.min.js n/a n/a 0 B 1.79 KB 0 B 895 B UMD_PROD
react-events-focus.development.js 0.0% -0.1% 6.99 KB 6.99 KB 1.79 KB 1.79 KB NODE_DEV
react-events-scroll.development.js n/a n/a 0 B 3.74 KB 0 B 1.17 KB NODE_DEV
react-events-focus.production.min.js 0.0% -0.1% 2.9 KB 2.9 KB 1.11 KB 1.11 KB NODE_PROD
react-events-scroll.production.min.js n/a n/a 0 B 1.59 KB 0 B 808 B NODE_PROD
ReactEventsScroll-prod.js n/a n/a 0 B 3.32 KB 0 B 1.01 KB FB_WWW_PROD
react-events-hover.development.js 0.0% -0.0% 8.91 KB 8.91 KB 2.14 KB 2.14 KB NODE_DEV
react-events-drag.development.js 0.0% 0.0% 7.61 KB 7.61 KB 2.33 KB 2.33 KB NODE_DEV
react-events-hover.production.min.js 0.0% -0.1% 3.68 KB 3.68 KB 1.38 KB 1.38 KB NODE_PROD
react-events-drag.production.min.js 0.0% -0.1% 3.17 KB 3.17 KB 1.46 KB 1.46 KB NODE_PROD
react-events-press.development.js 0.0% -0.0% 21.53 KB 21.53 KB 4.94 KB 4.94 KB UMD_DEV
react-events-swipe.development.js 0.0% -0.1% 6.29 KB 6.29 KB 1.79 KB 1.79 KB UMD_DEV
react-events-press.production.min.js 0.0% -0.1% 7.86 KB 7.86 KB 2.79 KB 2.79 KB UMD_PROD
react-events-swipe.production.min.js 0.0% -0.1% 2.68 KB 2.68 KB 1.25 KB 1.25 KB UMD_PROD
react-events-press.development.js 0.0% 0.0% 21.34 KB 21.34 KB 4.88 KB 4.89 KB NODE_DEV

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 73c27d8 into facebook:master Jun 5, 2019
@trueadm trueadm deleted the flare-scroll branch June 5, 2019 17:20
rickhanlonii pushed a commit to rickhanlonii/react that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants