-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Events] Adds existing event system behind enablePluginEventSystem flag #15840
[Events] Adds existing event system behind enablePluginEventSystem flag #15840
Conversation
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.4% Details of bundled changes.Comparing: def56c9...a86a2a5 react-dom
react-native-renderer
react-art
react-reconciler
Generated by 🚫 dangerJS |
I need to look into why the sizes have gone up. It's likely something with GCC and the fact there are now flags there that weren't there before. @sebmarkbage any ideas, I think you ran into something similar in the past where inlining changed because of flags? Every time I run the build I get a slightly different size with sizebot too it seems. |
Closing as we're no longer developing this API. See #15257 (comment) |
Note: this PR should make no changes to existing logic anywhere. Everything should continue to work as it does today. Also we don't expect to turn this flag of for the long foreseeable future.
This PR takes the existing event system call-sites and modules and wraps them in a
enablePluginEventSystem
flag. With this flag in place we can understand internally what parts of our application code use what events parts of the heritage event system. This flag also allows us to track metrics on code size of React Flare vs the heritage event system, as code size is important for us to manage.This PR also renames the existing React Flare event flag to something more descriptive -
enableResponderEventSystem
.