-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useCallback not work properly in shallow renderer #15843
Fix useCallback not work properly in shallow renderer #15843
Conversation
Details of bundled changes.Comparing: 3b23022...b067a9f react-test-renderer
Generated by 🚫 dangerJS |
@threepointone @gaearon sorry for pinging. any news on this? |
I don't think we're going to add this functionality to the shallow renderer for now, sorry. I truly appreciate the effort. |
@threepointone why not? |
Sorry, I think I read the conclusion on the linked task wrongly. I'll reopen this, but I'm still not certain what our plans are for adding this to the shallow renderer. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
This isn't stale, it's just that collaborators haven't made a decision yet. (Please don't use stalebots, they're incredibly user-hostile) |
The shallow renderer has moved to https://github.com/NMinhNguyen/react-shallow-renderer. If this is still relevant, please feel free to file this issue there. Thanks! |
Fix #15774 .
Just copy and paste the same logic as
useMemo
in shallow renderer; Not sure if it's better to extract the comparison logic into common function or just keep it repeat.