Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[act] flush work correctly without a mocked scheduler #16223

Merged
merged 1 commit into from
Jul 26, 2019
Merged

[act] flush work correctly without a mocked scheduler #16223

merged 1 commit into from
Jul 26, 2019
+197 −3

Commits on Jul 26, 2019

  1. [act] flush work correctly without a mocked scheduler 

    Not returning the value of flushPassiveEffects() in flushWork() meant that with async act, we wouldn't flush all work with cascading effects. This PR fixes that oversight, and adds some tests to catch this in the future.
    @threepointone
    threepointone committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    ea134ae View commit details
    Browse the repository at this point in the history