Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-devtools-shared] Added string type check for object name prop in getDisplayName function #16798

Merged
merged 3 commits into from
Sep 17, 2019
Merged

[react-devtools-shared] Added string type check for object name prop in getDisplayName function #16798

merged 3 commits into from
Sep 17, 2019

Commits on Sep 16, 2019

  1. [react-devtools-shared] Added string type check for object name prop … 

    …in getDisplayName function from utils.js file; tests included;
    @LetItRock
    LetItRock committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    d0106c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Re-added empty string check to getDisplayName()

    @bvaughn
    bvaughn committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    2556fac View commit details
    Browse the repository at this point in the history

  2. Tweaked tests to use real functions 

    This more closely simulates how the utility is being used in production, and would catch cases like anonymous functions (with empty string names).
    @bvaughn
    bvaughn committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    43e09fe View commit details
    Browse the repository at this point in the history