Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-test-renderer: improve findByType() error message #17439

Merged
merged 3 commits into from
Feb 28, 2020
Merged

react-test-renderer: improve findByType() error message #17439

merged 3 commits into from
Feb 28, 2020

Commits on Feb 28, 2020

  1. improve findByType error message

    @henryqdineen
    henryqdineen committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    47c1509 View commit details
    Browse the repository at this point in the history

  2. fix flow typing

    @henryqdineen
    henryqdineen committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    74a3e77 View commit details
    Browse the repository at this point in the history

  3. Adding a test for the "Unknown" branch when getComponentName() retu… 

    …rns a falsy value. The error message in this case not the most descriptive but seems consistent with the `getComponentName(type) || 'Unknown'` pattern seen in multiple places in this code base.
    @henryqdineen
    henryqdineen committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    72ff92a View commit details
    Browse the repository at this point in the history