Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades us to the latest version of Jest. Unfortunately, we run into issues doing this due to the fact newer versions of JSDOM require
testURL
to behttp://localhost
. Historically, this has beenabout:blank
for our tests, because we depend on behavior differences in JSDOM that ensure our existing tests work as expected and changing thetestURL
(as I've done in this PR) now causes many of our tests to fail. As per the comment in ourconfig.base.js
by @SimenB :I'm unsure as to how we can resolve this. Maybe @SimenB has some ideas?