Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not for merge] WWW sync #18381

Closed
wants to merge 5 commits into from
Closed

[Not for merge] WWW sync #18381

wants to merge 5 commits into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 24, 2020

This includes #18380 but doesn't include #18377 so that I could still layer it on top.

This fixes the bug.
These aren't directly observable. The arg wasn't used, it's accidental and I forgot to remove. The retval was triggering a codepath that was unnecessary (pushing to array) so I removed that too.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 24, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 664b936:

Sandbox Source
suspicious-https-41zgn Configuration

@sizebot
Copy link

sizebot commented Mar 24, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 664b936

@sizebot
Copy link

sizebot commented Mar 24, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 664b936

@gaearon gaearon closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants