Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-dom): Add enterKeyHint #18634

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 16, 2020

Summary

-<input enterkeyhint="search" />
+<input enterKeyHint="search" />

Test Plan

Ran /fixtures/attribute-behavior locally. Results available under https://drive.google.com/open?id=1j5PJgc-NcKXsGZh8GqBfHXHfdEwd9ii_.

Note: Should I update the fixture for inputMode as well? It is still reading from the attribute but the property is supported as of chrome 66.

{name: 'inputMode', tagName: 'input', read: getAttribute('inputmode')}, // TODO: Should use property but it's not implemented in Chrome

Codesandbox using this PR: https://codesandbox.io/s/enterkeyhint-6l5t3

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c75389:

Sandbox Source
festive-franklin-f39ug Configuration

@sizebot
Copy link

sizebot commented Apr 16, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 8c75389

@sizebot
Copy link

sizebot commented Apr 16, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 8c75389

@eps1lon eps1lon closed this Apr 28, 2020
@eps1lon eps1lon deleted the feat/enterkeyhint branch April 28, 2020 19:15
@eps1lon eps1lon restored the feat/enterkeyhint branch April 28, 2020 19:15
@eps1lon eps1lon reopened this Apr 28, 2020
@eps1lon
Copy link
Collaborator Author

eps1lon commented Apr 28, 2020

deleted by accident

@stale
Copy link

stale bot commented Jul 27, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jul 27, 2020
@eps1lon
Copy link
Collaborator Author

eps1lon commented Jul 27, 2020

bump

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jul 27, 2020
@gaearon gaearon merged commit feb134c into facebook:master Jul 27, 2020
@gaearon
Copy link
Collaborator

gaearon commented Jul 27, 2020

Looks like we forgot to merge. Thanks!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants