Fix flushing suspense fallbacks at the end of Act when the scheduler is mocked #19471
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a27a0d7:
|
rickhanlonii
force-pushed
the
rh-fix-act-fallbacks
branch
from
0e37320
to
a27a0d7
Compare
| // Flush callbacks at the end. | ||
| return isFlushingAct; | ||
| } | ||
|
|
||
| // `IsThisRendererActing.current` is used by ReactTestUtils version of `act`. | ||
| if (IsThisRendererActing.current) { |
There was a problem hiding this comment.
The core issue for the bug I'm fixing is that IsThisRendererActing.current is not reset to false before we check shouldForceFlushFallbacksInDEV, meaning that we miss the isFlushingAct = true value, and we schedule the fallback here instead of committing it.
There was a problem hiding this comment.
@acdlite what was the expected behavior here? Should we be checking for isFlushingAct first?
Is the test that failed correct or is it actually wrong?
|
I think we need to start over on the act stuff. It's too convoluted. I'm loath to add another hacky workaround. To unblock the RN sync, can you mitigate by disabling the test or something? This doesn't seem important enough to block the whole sync. |
|
Yeah I can do that 👍 |
Overview
WIP - I think this treats the symptom and not the cause, but shows the issue, what works, and what tests break.