Fix muted prop not being shown as an attribute for video elements #20087

antoniopacheco · 2020-10-23T22:15:02Z

Summary

Test Plan

Currently there is an issue with jest so whenever we try to test <video muted/.> we get a
Warning: unstable_flushDiscreteUpdates: Cannot flush updates when React is already rendering found on:
testing-library/react-testing-library#470

in order to fix this bug we need to have a muted attribute in the element before we set the prop, that's why you can see the timeout. so it won't detect a change in the volume once the prop is set.

codesandbox-ci · 2020-10-23T22:17:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d5b38d1:

Sandbox	Source
React	Configuration

sizebot · 2020-10-23T22:22:45Z

Details of bundled changes.

Comparing: 4e5d7fa...d5b38d1

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.development.js	+0.1%	+0.1%	872.67 KB	873.92 KB	199.75 KB	199.91 KB	NODE_DEV
ReactDOMForked-prod.js	🔺+0.2%	🔺+0.1%	383.9 KB	384.73 KB	70.83 KB	70.89 KB	FB_WWW_PROD
react-dom-server.node.development.js	+0.6%	+0.2%	137.05 KB	137.89 KB	36.37 KB	36.45 KB	NODE_DEV
react-dom.production.min.js	🔺+0.2%	🔺+0.1%	117.75 KB	118.01 KB	37.95 KB	38 KB	NODE_PROD
ReactDOMForked-profiling.js	+0.2%	+0.1%	399.12 KB	399.94 KB	73.46 KB	73.53 KB	FB_WWW_PROFILING
react-dom-server.browser.development.js	+0.6%	+0.2%	143.13 KB	144.02 KB	36.57 KB	36.64 KB	UMD_DEV
react-dom-server.node.production.min.js	🔺+0.7%	🔺+0.2%	20.2 KB	20.33 KB	7.58 KB	7.6 KB	NODE_PROD
ReactDOMTesting-dev.js	+0.1%	+0.1%	940.73 KB	942.03 KB	210.75 KB	210.94 KB	FB_WWW_DEV
ReactDOMTesting-prod.js	🔺+0.2%	🔺+0.1%	384.74 KB	385.54 KB	72.38 KB	72.45 KB	FB_WWW_PROD
react-dom.development.js	+0.1%	+0.1%	917.09 KB	918.41 KB	202.29 KB	202.46 KB	UMD_DEV
react-dom.production.min.js	🔺+0.2%	🔺+0.1%	117.65 KB	117.91 KB	38.64 KB	38.69 KB	UMD_PROD
react-dom.profiling.min.js	+0.2%	+0.1%	121.55 KB	121.81 KB	39.85 KB	39.89 KB	UMD_PROFILING
ReactDOMForked-dev.js	+0.1%	+0.1%	992.51 KB	993.81 KB	219.62 KB	219.81 KB	FB_WWW_DEV
react-dom.profiling.min.js	+0.2%	+0.1%	121.83 KB	122.09 KB	39.13 KB	39.18 KB	NODE_PROFILING
react-dom-server.browser.production.min.js	🔺+0.7%	🔺+0.2%	19.87 KB	20.01 KB	7.46 KB	7.47 KB	UMD_PROD
ReactDOM-dev.js	+0.1%	+0.1%	980.82 KB	982.12 KB	218.04 KB	218.24 KB	FB_WWW_DEV
ReactDOM-prod.js	🔺+0.2%	🔺+0.1%	381.46 KB	382.29 KB	70.32 KB	70.38 KB	FB_WWW_PROD
react-dom-server.browser.development.js	+0.6%	+0.2%	135.79 KB	136.62 KB	36.12 KB	36.2 KB	NODE_DEV
ReactDOM-profiling.js	+0.2%	+0.1%	395.14 KB	395.96 KB	72.79 KB	72.85 KB	FB_WWW_PROFILING
react-dom-server.browser.production.min.js	🔺+0.7%	🔺+0.3%	19.77 KB	19.91 KB	7.42 KB	7.44 KB	NODE_PROD
ReactDOMServer-dev.js	+0.6%	+0.2%	145.51 KB	146.4 KB	37.29 KB	37.36 KB	FB_WWW_DEV
ReactDOMServer-prod.js	🔺+1.2%	🔺+0.2%	47.29 KB	47.85 KB	11.03 KB	11.06 KB	FB_WWW_PROD

Size changes (stable)

Generated by 🚫 dangerJS against d5b38d1

sizebot · 2020-10-23T22:24:31Z

Details of bundled changes.

Comparing: 4e5d7fa...d5b38d1

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.development.js	+0.1%	+0.1%	908.22 KB	909.47 KB	206.3 KB	206.46 KB	NODE_DEV
ReactDOMForked-prod.js	🔺+0.2%	🔺+0.1%	372.58 KB	373.4 KB	68.99 KB	69.06 KB	FB_WWW_PROD
react-dom-server.node.development.js	+0.6%	+0.2%	138.57 KB	139.4 KB	36.58 KB	36.66 KB	NODE_DEV
react-dom.production.min.js	🔺+0.2%	🔺+0.2%	122.29 KB	122.55 KB	39.3 KB	39.36 KB	NODE_PROD
ReactDOMForked-profiling.js	+0.2%	+0.1%	387.75 KB	388.57 KB	71.63 KB	71.7 KB	FB_WWW_PROFILING
react-dom-server.browser.development.js	+0.6%	+0.2%	144.72 KB	145.61 KB	36.76 KB	36.84 KB	UMD_DEV
react-dom-server.node.production.min.js	🔺+0.7%	🔺+0.2%	20.66 KB	20.79 KB	7.65 KB	7.67 KB	NODE_PROD
react-dom-test-utils.production.min.js	0.0%	0.0%	13.71 KB	13.71 KB	5.32 KB	5.32 KB	UMD_PROD
ReactDOMTesting-dev.js	+0.1%	+0.1%	912.39 KB	913.69 KB	205.23 KB	205.39 KB	FB_WWW_DEV
ReactDOMTesting-prod.js	🔺+0.2%	🔺+0.1%	371.68 KB	372.48 KB	70.18 KB	70.23 KB	FB_WWW_PROD
react-dom-unstable-fizz.node.development.js	0.0%	+0.1%	5.52 KB	5.52 KB	1.84 KB	1.84 KB	NODE_DEV
react-dom-test-utils.production.min.js	0.0%	0.0%	13.7 KB	13.7 KB	5.26 KB	5.27 KB	NODE_PROD
react-dom-unstable-fizz.node.production.min.js	0.0%	-0.1%	1.17 KB	1.17 KB	667 B	666 B	NODE_PROD
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	4.78 KB	4.78 KB	1.68 KB	1.68 KB	NODE_DEV
react-dom.development.js	+0.1%	+0.1%	954.39 KB	955.72 KB	208.87 KB	209.03 KB	UMD_DEV
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.2%	1.01 KB	1.01 KB	616 B	617 B	NODE_PROD
react-dom.production.min.js	🔺+0.2%	🔺+0.2%	122.12 KB	122.38 KB	40.02 KB	40.09 KB	UMD_PROD
react-dom.profiling.min.js	+0.2%	+0.2%	127.38 KB	127.64 KB	41.65 KB	41.73 KB	UMD_PROFILING
ReactDOMForked-dev.js	+0.1%	+0.1%	966.93 KB	968.23 KB	214.85 KB	215.02 KB	FB_WWW_DEV
react-dom.profiling.min.js	+0.2%	+0.2%	127.73 KB	128 KB	40.95 KB	41.02 KB	NODE_PROFILING
react-dom-server.browser.production.min.js	🔺+0.7%	🔺+0.2%	20.33 KB	20.47 KB	7.55 KB	7.56 KB	UMD_PROD
ReactDOM-dev.js	+0.1%	+0.1%	955.24 KB	956.54 KB	213.35 KB	213.52 KB	FB_WWW_DEV
ReactDOM-prod.js	🔺+0.2%	🔺+0.1%	370.21 KB	371.03 KB	68.54 KB	68.61 KB	FB_WWW_PROD
react-dom-server.browser.development.js	+0.6%	+0.2%	137.3 KB	138.13 KB	36.33 KB	36.41 KB	NODE_DEV
ReactDOM-profiling.js	+0.2%	+0.1%	383.84 KB	384.66 KB	71.03 KB	71.1 KB	FB_WWW_PROFILING
react-dom-server.browser.production.min.js	🔺+0.7%	🔺+0.3%	20.23 KB	20.37 KB	7.49 KB	7.51 KB	NODE_PROD
ReactDOMServer-dev.js	+0.6%	+0.2%	141.48 KB	142.37 KB	36.28 KB	36.35 KB	FB_WWW_DEV
ReactDOMServer-prod.js	🔺+1.2%	🔺+0.1%	46.43 KB	46.98 KB	10.82 KB	10.83 KB	FB_WWW_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against d5b38d1

atnpcg · 2021-02-04T22:50:39Z

any love for this PR?

iHildy · 2021-04-28T12:15:50Z

Any hope for this PR?

…ct into fix-10389-video-muted

stale · 2022-01-08T23:41:50Z

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

swissspidy · 2022-01-09T12:35:39Z

bump

vctqs1 · 2022-01-28T05:44:14Z

bump

viclafouch · 2023-06-21T08:53:35Z

Bummmmmmmp

github-actions · 2024-04-10T15:40:39Z

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions · 2024-04-17T18:12:03Z

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

Fix muted prop not being shown as an attribute for video elements

4017c70

This was referenced Oct 23, 2020

<video /> attribute needed but not guaranteed by React #10389

Open

Rendering Using 'muted' attribute in a video tag prints a warning about flushing updates to the console. testing-library/react-testing-library#470

Closed

facebook-github-bot added the CLA Signed label Oct 23, 2020

Format run prettier

38beab2

atnpcg added 3 commits October 23, 2020 15:31

Fix flow

5df3879

Fix incorrect boolean being imported

be8b1d0

Test add testing for video muted

d5b38d1

atnpcg and others added 6 commits August 9, 2021 12:15

Fix muted prop not being shown as an attribute for video elements

3892f67

Format run prettier

d6c31c3

Fix flow

648f6e8

Test add testing for video muted

9b2616a

Merge branch 'fix-10389-video-muted' of github.com:antoniopacheco/rea…

2940ad7

…ct into fix-10389-video-muted

Merge branch 'facebook:main' into fix-10389-video-muted

527f1a3

antoniopacheco changed the base branch from master to 0.3-stable August 11, 2021 03:37

antoniopacheco changed the base branch from 0.3-stable to main August 11, 2021 03:37

stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 8, 2022

stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2022

github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024

github-actions bot closed this Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix muted prop not being shown as an attribute for video elements #20087

Fix muted prop not being shown as an attribute for video elements #20087

antoniopacheco commented Oct 23, 2020 •

edited

Loading

codesandbox-ci bot commented Oct 23, 2020 •

edited

Loading

sizebot commented Oct 23, 2020 •

edited

Loading

react-dom

sizebot commented Oct 23, 2020 •

edited

Loading

react-dom

atnpcg commented Feb 4, 2021

iHildy commented Apr 28, 2021

stale bot commented Jan 8, 2022

swissspidy commented Jan 9, 2022

vctqs1 commented Jan 28, 2022

viclafouch commented Jun 21, 2023

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 17, 2024

Fix muted prop not being shown as an attribute for video elements #20087

Fix muted prop not being shown as an attribute for video elements #20087

Conversation

antoniopacheco commented Oct 23, 2020 • edited Loading

Summary

Test Plan

codesandbox-ci bot commented Oct 23, 2020 • edited Loading

sizebot commented Oct 23, 2020 • edited Loading

react-dom

Size changes (stable)

sizebot commented Oct 23, 2020 • edited Loading

react-dom

Size changes (experimental)

atnpcg commented Feb 4, 2021

iHildy commented Apr 28, 2021

stale bot commented Jan 8, 2022

swissspidy commented Jan 9, 2022

vctqs1 commented Jan 28, 2022

viclafouch commented Jun 21, 2023

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 17, 2024

antoniopacheco commented Oct 23, 2020 •

edited

Loading

codesandbox-ci bot commented Oct 23, 2020 •

edited

Loading

sizebot commented Oct 23, 2020 •

edited

Loading

sizebot commented Oct 23, 2020 •

edited

Loading