-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix muted prop not being shown as an attribute for video elements #20087
Fix muted prop not being shown as an attribute for video elements #20087
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d5b38d1:
|
Details of bundled changes.Comparing: 4e5d7fa...d5b38d1 react-dom
Size changes (stable) |
Details of bundled changes.Comparing: 4e5d7fa...d5b38d1 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
any love for this PR? |
Any hope for this PR? |
…ct into fix-10389-video-muted
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump |
bump |
Bummmmmmmp |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Fixes: #10389
Test Plan
Currently there is an issue with jest so whenever we try to test <video muted/.> we get a
Warning: unstable_flushDiscreteUpdates: Cannot flush updates when React is already rendering
found on:testing-library/react-testing-library#470
in order to fix this bug we need to have a muted attribute in the element before we set the prop, that's why you can see the timeout. so it won't detect a change in the volume once the prop is set.