Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double Invoke Effects in __DEV__ (in old reconciler fork) #20415

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Double Invoke Effects in __DEV__ (in old reconciler fork) #20415

merged 1 commit into from
Dec 9, 2020
+1,099 −50

Commits on Dec 9, 2020

  1. Double Invoke Effects in __DEV__ (in old reconciler fork) 

    We originally added a new DEV behavior of double-invoking effects during mount to our new reconciler fork in PRs facebook#19523 and facebook#19935 and later refined it to only affect modern roots in PR facebook#20028. This PR adds that behavior to the old reconciler fork with a small twist– the behavior applies to StrictMode subtrees, regardless of the root type.

This commit also adds a few additional tests that weren't in the original commits.
    Brian Vaughn committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    9072299 View commit details
    Browse the repository at this point in the history