Switch on enableProfilerChangedHookIndices flag for OSS devtools builds #22011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder why the CI didn't run properly on this branch 🤔 |
bvaughn
approved these changes
Aug 3, 2021
Huh yeah, weird. In any case, thanks for merging this (: Is there a regular external release schedule for the extension? When might this make it to the extension stores? |
jstejada
pushed a commit
to jstejada/react
that referenced
this pull request
Aug 6, 2021
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on thread of #20998. That PR added functionality behind an FB-only flag —namely showing which hooks (indices) changed on profiles that capture the reasons behind re-render. This functionality is useful beyond just Facebook. This diff enables it for OSS builds, so that everyone else can use it too.
Test Plan
Built the extension and conforirmed hook indeces appear under "Why did this render?" in the profiler (on both Chrome and Firefox). ✅
Ran the test suite, just in case. ✅