Build use-sync-external-store in codesandbox-ci #22352
Closed
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: f50ff35...f327419 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
Would rather not merge this because it's slippery slope to adding all our packages to the CodeSandbox CI job. I would prefer to update the CodeSandbox config to pull the packages from CircleCI artifacts, like most of our other scripts have been updated to do. But for your use case, what you could do instead is: or in your package.json Example with CodeSandbox: https://codesandbox.io/s/billowing-dust-pmps8?file=/package.json:225-338 |
|
Oh codesandbox didnt used to support this, thanks! |
I pinged them on Twitter and they fixed it haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wanted to play around with #22347 but
use-sync-external-storeisn't built in codesandbox-ci. For React 18 repros it isn't that big of deal since I can just use the variant exported fromreact. Bur for older React versions I need the shim form the package.How did you test this change?
use-sync-external-storefrom this PR in https://codesandbox.io/s/pedantic-archimedes-9q0nb?file=/src/App.js: https://codesandbox.io/s/sleepy-moon-d561m