-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native raw event EventEmitter - intended for app-specific perf listeners and debugging #23232
Merged
JoshuaGross
merged 17 commits into
facebook:main
from
JoshuaGross:jgross-ReactNativeEventTelemetryPlugin
Feb 8, 2022
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
dd754e6
ReactNativeEventTelemetryPlugin: new event perf profiling mechanism o…
JoshuaGross ac7915f
sync
JoshuaGross 0125355
concise notation
JoshuaGross d04781d
Move event telemetry event emitter call from Plugin to ReactFabricEve…
JoshuaGross 4b72b07
Backout changes to ReactNativeEventPluginOrder
JoshuaGross 7e76ce6
Properly flow typing event emitter, and emit event to two channels: n…
JoshuaGross 97a1b0f
fix typing for event name string
JoshuaGross a6deda3
fix typing for event name string
JoshuaGross bc6905c
fix flow
JoshuaGross d9a85fe
Add more comments about how the event telemetry system works
JoshuaGross 229595d
Add more comments about how the event telemetry system works
JoshuaGross 1825e07
rename to RawEventTelemetryEventEmitterOffByDefault
JoshuaGross 0eef8e9
yarn prettier-all
JoshuaGross bbf3f78
rename event
JoshuaGross bff359e
comments
JoshuaGross 62124f3
improve flow types
JoshuaGross 143b04b
renamed file
JoshuaGross File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
..._mocks__/react-native/Libraries/ReactPrivate/RawEventTelemetryEventEmitterOffByDefault.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// See the react-native repository for a full implementation. | ||
// However, this is just an EventEmitter. | ||
const RawEventTelemetryEventEmitterOffByDefault = { | ||
emit: jest.fn(), | ||
}; | ||
|
||
module.exports = {default: RawEventTelemetryEventEmitterOffByDefault}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we name this somehow to make it clearer this is opt-in and that RN does not collect any telemetry by default? I can absolutely see someone “finding” it in code and writing an HN article about it. Same goes for the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: RawEventTelemetryOffByDefault :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an extremely valid concern.