Fizz: Prevent UnhandledPromiseRejectionWarning
if renderToReadableStream
throws
#24043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed a
UnhandledPromiseRejectionWarning
when running tests (e.g. https://app.circleci.com/pipelines/github/facebook/react/24649/workflows/5b1b67a2-eb4b-4e7e-9dd8-d531328eff6e/jobs/448950/parallel-runs/16).It seems to me that
stream.allReady
is not accessible when the shell errors (i.e.renderToReadableStream
throws) which meansstream.allReady
will be left rejected and unhandled.How did you test this change?
yarn test ReactDOMFizzServerBrowser
logs noUnhandledPromiseRejectionWarning
ReactDOMFizzServerBrowser
logs noUnhandledPromiseRejectionWarning
in CI: https://app.circleci.com/pipelines/github/facebook/react/24655/workflows/ad4851cf-0530-4a69-8c36-e7a9bcaf7daa/jobs/449075/parallel-runs/14Follow-up?