Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the word 'own' to the README file for design consistency #25185

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

Bchan1999
Copy link
Contributor

Summary

After comparing the README file Component-Based description with the description on the React website, I noticed the README file was missing the word "own". For design consistency I added the word.
image

Reference: https://reactjs.org/

How did you test this change?

Since there was no change to the code and only the README file was modified, I ran no tests.

@sizebot
Copy link

sizebot commented Sep 4, 2022

Comparing: f0efa11...dbe2a30

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 134.97 kB 134.97 kB = 43.23 kB 43.23 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 141.64 kB 141.64 kB = 45.20 kB 45.20 kB
facebook-www/ReactDOM-prod.classic.js = 486.06 kB 486.06 kB = 86.51 kB 86.51 kB
facebook-www/ReactDOM-prod.modern.js = 471.34 kB 471.34 kB = 84.29 kB 84.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 486.06 kB 486.06 kB = 86.51 kB 86.51 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against dbe2a30

@rbalicki2
Copy link
Contributor

Looks good! Thanks for finding and fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants