Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental_useEvent #25229

Merged
merged 9 commits into from
Sep 14, 2022
Merged

experimental_useEvent #25229

merged 9 commits into from
Sep 14, 2022

Commits on Sep 14, 2022

  1. Add useEvent

    @rickhanlonii @poteto
    rickhanlonii authored and poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    7797d83 View commit details
    Browse the repository at this point in the history

  2. Add test checking that useEvent is updated in hook snapshot phase 

    Co-authored-by: Lauren Tan <[email protected]>
    @rickhanlonii @poteto
    rickhanlonii and poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c00ffe8 View commit details
    Browse the repository at this point in the history

  3. Make useEvent gated as experimental

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    deb67f3 View commit details
    Browse the repository at this point in the history

  4. Add tests from docs examples

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    38c2b01 View commit details
    Browse the repository at this point in the history

  5. Address feedback (will be squashed)

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    ba846ba View commit details
    Browse the repository at this point in the history

  6. Drop .internal from useEvent-test.js

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    eaa47a7 View commit details
    Browse the repository at this point in the history

  7. Add test for this context

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    a4af797 View commit details
    Browse the repository at this point in the history

  8. Remove todo comment

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    691b1bd View commit details
    Browse the repository at this point in the history

  9. Update tests to pass event function via a closure instead

    @poteto
    poteto committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    7583f13 View commit details
    Browse the repository at this point in the history