Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to load Fizz runtime from external file #25499

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Add option to load Fizz runtime from external file #25499

merged 2 commits into from
Oct 17, 2022

Commits on Oct 17, 2022

  1. Add feature flag for external Fizz runtime 

    Only enabled for www for now
    @acdlite
    acdlite committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    b6a5304 View commit details
    Browse the repository at this point in the history

  2. Add option to load Fizz runtime from external file 

    When unstable_externalRuntimeSrc is provided, React will inject a script
tag that points to the provided URL.

Then, instead of emitting inline scripts, the Fizz stream will emit
HTML nodes with data attributes that encode the instructions. The
external runtime will detect these with a mutation observer and
translate them into runtime commands. This part isn't implemented in 
this PR, though — all this does is set up the option to use 
an external runtime, and inject the script tag.

The external runtime is injected at the same time as bootstrap scripts.
    @acdlite
    acdlite committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    68a25c1 View commit details
    Browse the repository at this point in the history