Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transposed escape functions #25534

Merged
merged 4 commits into from
Oct 22, 2022
Merged

fix transposed escape functions #25534

merged 4 commits into from
Oct 22, 2022

Commits on Oct 22, 2022

  1. fix transposed escape functions

    @gnoff
    gnoff committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3acba95 View commit details
    Browse the repository at this point in the history

  2. add flow to escapeTextForBrowser to prevent future issues

    @gnoff
    gnoff committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    796bfd7 View commit details
    Browse the repository at this point in the history

  3. make Chunk types opaque where possible 

    Previously Chunks were not opaque so you could construct conincidental types that satisifed the type condition but were not routed through a Chunk factory. This is dangerous because it allows for things like the transpoition of escaping and chunking which has led to bugs in certain environments.

Ideally all chunk types would be opaque however the ReactNative Fizz runtime constructs type-compatible entries with PrecomputedChunk without calling into the Chunk factory. This should be fixed but is outside the scope of this change so I left those not opaque where they would otherwise lead to new type errors
    @gnoff
    gnoff committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3ba6560 View commit details
    Browse the repository at this point in the history

  4. add regression for title escaping in browser runtime

    @gnoff
    gnoff committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    e47291d View commit details
    Browse the repository at this point in the history