Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async test in React reconciler #26087

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Fix async test in React reconciler #26087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c18d44
Fix async test in React reconciler
ymqy Feb 1, 2023
44e3fa8
Merge branch 'main' into fix/async-test
ymqy Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ describe('updaters', () => {
Scheduler.unstable_flushAll();
});

it('should cover suspense pings', async done => {
it('should cover suspense pings', async () => {
let data = null;
let resolver = null;
let promise = null;
Expand Down Expand Up @@ -312,8 +312,6 @@ describe('updaters', () => {

// Verify no outstanding flushes
Scheduler.unstable_flushAll();

done();
});

it('should cover error handling', async () => {
Expand Down