add note re: handling events in capture phase #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
I've now signed the CLA. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -35,7 +35,7 @@ String type | |||
| ## Supported Events | |||
|
|
|||
| React normalizes events so that they have consistent properties across | |||
| different browsers. | |||
| different browsers. The event handlers below are triggered by an event in the bubbling phase; to register an event handler for the capture phase, append "Capture" to the event name (for example: onClick -> onClickCapture). | |||
There was a problem hiding this comment.
I think this sounds pretty good. Just a little tweak:
- Let's use backticks around the event names so they use code formatting
- "(for example: onClick -> onClickCapture)" can be it's own sentence. "Instead of using
onClick, you would useonClickCaptureto handle the click event in the capture phase" ... or something like that.
use backticks and change example into its own sentence
|
@zpao, made the changes |
|
Thanks! |
zpao
added a commit
that referenced
this pull request
Dec 2, 2014
add note re: handling events in capture phase
zpao
added a commit
that referenced
this pull request
Dec 3, 2014
add note re: handling events in capture phase
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't find any mention in the documentation on how to handle events during the capture phase. I added a sentence in the events documentation to explain the "...Capture" syntax. Feel free to move the explanation elsewhere.