Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] reduce dynamic SchedulerFeatureFlags #26617

Merged
merged 3 commits into from
May 10, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 13, 2023

For these values we're not using dynamic values. We can statically compile in the values we're running.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 13, 2023
@react-sizebot
Copy link

react-sizebot commented Apr 13, 2023

Comparing: 7ac5e9a...f153571

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.19 kB 164.19 kB = 51.78 kB 51.78 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.55 kB 171.55 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 570.13 kB 570.13 kB = 100.62 kB 100.62 kB
facebook-www/ReactDOM-prod.modern.js = 553.87 kB 553.87 kB = 97.80 kB 97.80 kB
facebook-www/Scheduler-profiling.classic.js = 16.01 kB 15.40 kB = 3.72 kB 3.63 kB
facebook-www/Scheduler-profiling.modern.js = 16.01 kB 15.40 kB = 3.72 kB 3.63 kB
facebook-www/Scheduler-prod.classic.js = 11.84 kB 11.25 kB = 2.93 kB 2.82 kB
facebook-www/Scheduler-prod.modern.js = 11.84 kB 11.25 kB = 2.93 kB 2.82 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/SchedulerMock-prod.classic.js = 12.57 kB 12.48 kB = 2.97 kB 2.94 kB
facebook-www/SchedulerMock-prod.modern.js = 12.57 kB 12.48 kB = 2.97 kB 2.94 kB
facebook-www/SchedulerMock-dev.classic.js = 23.63 kB 23.44 kB = 5.54 kB 5.48 kB
facebook-www/SchedulerMock-dev.modern.js = 23.63 kB 23.44 kB = 5.54 kB 5.48 kB
facebook-www/Scheduler-dev.classic.js = 26.09 kB 25.64 kB = 6.87 kB 6.78 kB
facebook-www/Scheduler-dev.modern.js = 26.09 kB 25.64 kB = 6.87 kB 6.78 kB
facebook-www/Scheduler-profiling.classic.js = 16.01 kB 15.40 kB = 3.72 kB 3.63 kB
facebook-www/Scheduler-profiling.modern.js = 16.01 kB 15.40 kB = 3.72 kB 3.63 kB
facebook-www/Scheduler-prod.classic.js = 11.84 kB 11.25 kB = 2.93 kB 2.82 kB
facebook-www/Scheduler-prod.modern.js = 11.84 kB 11.25 kB = 2.93 kB 2.82 kB

Generated by 🚫 dangerJS against f153571

@kassens kassens merged commit df12d7e into facebook:main May 10, 2023
@kassens kassens deleted the www-scheduler-flags branch May 10, 2023 21:26
github-actions bot pushed a commit that referenced this pull request May 10, 2023
For these values we're not using dynamic values. We can statically
compile in the values we're running.

DiffTrain build for [df12d7e](df12d7e)
noahlemen added a commit that referenced this pull request Jan 9, 2024
## Summary

these were removed in #26617. adds
them back so we can conduct another experiment.

## How did you test this change?
`yarn test-www`
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
## Summary

these were removed in #26617. adds
them back so we can conduct another experiment.

## How did you test this change?
`yarn test-www`

DiffTrain build for [c81f4e0](c81f4e0)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
For these values we're not using dynamic values. We can statically
compile in the values we're running.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
## Summary

these were removed in facebook#26617. adds
them back so we can conduct another experiment.

## How did you test this change?
`yarn test-www`
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
For these values we're not using dynamic values. We can statically
compile in the values we're running.

DiffTrain build for commit df12d7e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants