Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Update flushSync tests to use react-dom #28490

Merged
merged 1 commit into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. [Test] Update flushSync tests to use react-dom

    Updates the FlushSync tests to use react-dom instead of ReactNoop. flushSync is primarily a react-dom API and asserting the implementation of ReactNoop is not really ideal especially since we are going to be refactoring flushSync soon to not be implemented in the reconciler internals.
    
    ReactNoop still have a flushSync api and it can still be used in other tests that are primarily about testing other functionlity and use ReactNoop as the renderer.
    gnoff committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    012445d View commit details
    Browse the repository at this point in the history