[Flight] Add failing test to reproduce issue with Object.freeze
#29129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 3f1436c...3e6397f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Thank you for the minimal repro! |
unstubbable
force-pushed
the
object-freeze-failing-test
branch
from
e52afc3
to
ef1f50f
Compare
unstubbable
force-pushed
the
object-freeze-failing-test
branch
from
ef1f50f
to
3e6397f
Compare
sebmarkbage
added a commit
that referenced
this pull request
May 17, 2024
… blocked (#29139) Fixed #29129. --------- Co-authored-by: Hendrik Liebau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a failing test that demonstrates the issue as reported by @eps1lon in #29032 (comment).
react/packages/react-client/src/ReactFlightClient.js
Line 644 in 3f1436c
When the props object is frozen, the Flight Client's model resolver can't mutate the parent object (i.e. the props) anymore, after the client component that was referenced in the props has been loaded.
react/packages/react-client/src/ReactFlightClient.js
Line 701 in 3f1436c