Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight Reply] retain listeners when resolving models with existing listeners #29207

Merged
merged 1 commit into from
May 21, 2024
Merged

[Flight Reply] retain listeners when resolving models with existing listeners #29207

merged 1 commit into from
May 21, 2024
+17 −2

Commits on May 21, 2024

  1. [Flight Reply] retain listeners when resolving models with existing l… 

    …isteners

In facebook#29201 a fix was made to ensure we don't "forget" about some listeners when handling cyclic chunks.
In facebook#29204 another fix was made for a special case when the chunk already has listeners before it first resolves.

This implements the followup fix for Flight Reply which was originally missed in facebook#29204

Co-Authored-by: Janka Uryga <[email protected]>
    @gnoff @lubieowoce
    gnoff and lubieowoce committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c7c7ef2 View commit details
    Browse the repository at this point in the history