Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Support MetaProperty #29752

Merged
merged 5 commits into from
Jun 8, 2024
Merged

feat(compiler): Support MetaProperty #29752

merged 5 commits into from
Jun 8, 2024

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented Jun 4, 2024

Summary

See #29737

How did you test this change?

As the feature requires module support and the test runner does currently not support running tests as modules, I could only test it via playground.

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 4:36pm

@react-sizebot
Copy link

react-sizebot commented Jun 4, 2024 •
edited
Loading

Comparing: c2ae9e2...3e3b017

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.11% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.44 kB 497.44 kB = 89.16 kB 89.16 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.26 kB 502.26 kB = 89.85 kB 89.85 kB
facebook-www/ReactDOM-prod.classic.js = 596.94 kB 596.94 kB = 105.24 kB 105.24 kB
facebook-www/ReactDOM-prod.modern.js = 571.12 kB 571.12 kB = 101.19 kB 101.19 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against 3e3b017

josephsavona
josephsavona approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

josephsavona
josephsavona requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i spoke too soon. I just double-checked what other meta properties there are and realized it isn't guaranteed to be an immutable object.

@nikeee nikeee marked this pull request as draft June 5, 2024 00:24
josephsavona
josephsavona reviewed Jun 8, 2024
View reviewed changes
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@josephsavona josephsavona marked this pull request as ready for review June 8, 2024 23:18
@josephsavona josephsavona merged commit f5af92d into facebook:main Jun 8, 2024
55 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 8, 2024
@josephsavona
feat(compiler): Support MetaProperty (#29752)
ebca743 
## Summary
See #29737

## How did you test this change?
As the feature requires module support and the test runner does
currently not support running tests as modules, I could only test it via
playground.

DiffTrain build for commit f5af92d.
@nikeee nikeee deleted the meta-property branch June 9, 2024 00:47
@eps1lon eps1lon mentioned this pull request Jun 13, 2024
Merged
@eps1lon eps1lon mentioned this pull request Jul 10, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikeee @react-sizebot @josephsavona @facebook-github-bot