Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Nearest Parent of an Errored Promise as its Owner #29814

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Use the Nearest Parent of an Errored Promise as its Owner #29814

merged 4 commits into from
Jun 11, 2024

Commits on Jun 11, 2024

  1. Stash the task for each Server Component 

    If this is happening on the server where the FlightClient generates objects
that will then be consumed again by the Flight server, we need to strip the
task out before serializing it since it's not serializable but it can be
restored from stack + owner.
    @sebmarkbage
    sebmarkbage committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5d4603f View commit details
    Browse the repository at this point in the history

  2. Use the parent as the owner and task 

    Whether that nearest parent is a Server Component or the nearest Fiber.
    @sebmarkbage
    sebmarkbage committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b4750d2 View commit details
    Browse the repository at this point in the history

  3. Use the name of the inner most parent for messages

    @sebmarkbage
    sebmarkbage committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d45bdd0 View commit details
    Browse the repository at this point in the history

  4. Remove outdated comment

    @sebmarkbage
    sebmarkbage committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    adc2f78 View commit details
    Browse the repository at this point in the history